risk acceptance expiration: keep link with findings #12737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request contains a potential authorization bypass vulnerability in the Jira resolution processing logic, where an attacker could potentially manipulate risk acceptance without proper authorization review, located in the dojo/jira_link/helper.py file.
Authorization Bypass in
|
| Vulnerability | Authorization Bypass |
|---|---|
| Description | In the Jira resolution processing logic, the code allows marking a finding as risk accepted based on Jira resolution name and configuration flags. This could allow an attacker to manipulate risk acceptance without proper authorization review. |
django-DefectDojo/dojo/jira_link/helper.py
Lines 1769 to 1782 in ffe989c
All finding details can be found in the DryRun Security Dashboard.
valentijnscholten
force-pushed
the
risk-acceptance-dont-break-link
branch
from
11281ad to
8dd0306
Compare
github-actions
bot
added
docker
New Migration
github-actions
bot
removed
docker
New Migration
valentijnscholten
force-pushed
the
risk-acceptance-dont-break-link
branch
from
8dd0306 to
5a371f0
Compare
Maffooch
approved these changes
Jul 9, 2025
hblankenship
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #11401 to not remove findings from a Risk Acceptance when it expires.
The change to
process_resolution_from_jirais just a code readability improvement.The change to
view_eng.htmlmakes the number of findings cell in the Risk Acceptance table clickable.The main reason for #11401 in january was to make sure expired risk acceptances were getting reflected in JIRA, so this PR adds some calls for that.
The PR also triggers a JIRA sync after a simple risk accept.
The PR also makes some changes to move the
save()call out of the jira helper class.[sc-11552]